nickstenning commented on code in PR #73244: URL: https://github.com/apache/airflow/pull/73244#discussion_r4035199458
########## airflow-core/newsfragments/73244.significant.rst: ########## @@ -0,0 +1,21 @@ +Task heartbeats are no longer retried by ``[workers] execution_api_retries`` + +Heartbeats had two overlapping retry mechanisms: the Task SDK API client retried +every request, including heartbeats, and the supervisor separately counted +consecutive heartbeat failures against ``[workers] max_failed_heartbeats``. The +client retries also had the unwanted side-effect of blocking the supervisor's +monitor loop while it backed off, so during an API server outage the supervisor Review Comment: I mean this all seems bad. 😆 I'm just trying to make it better. My interpretation of the newsfragments was that they were intended to be actionable. In this case "if you've customized `max_failed_heartbeats` you may want to revisit that." I'm not sure how to make a comment about the fact that other things can block the supervisor loop actionable, but I'm all ears if you have suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
