pankajastro opened a new pull request, #73287:
URL: https://github.com/apache/airflow/pull/73287

   Depends on #73273 — the plain-database-table `DataSourceConfig` shape this 
fixes doesn't exist until that merges. The diff below includes #73273's commit; 
check the "Commits" tab to see just this PR's own commit. Rebasing onto `main` 
once #73273 merges.
   
   Follow-up per [review 
feedback](https://github.com/apache/airflow/pull/73273#pullrequestreview-5235383645)
 on #73273.
   
   `LLMSQLOperator`, `DataFusionToolset`, and `AnalyticsOperator` hand 
`DataFusionEngine.register_datasource` whatever `DataSourceConfig` the caller 
supplies, unlike `LLMSchemaCompareOperator` which checks the connection kind 
first. A plain-database-table config reaching any of them failed deep inside 
credential resolution with a confusing `Unknown connection type` error instead 
of a clear message. `register_datasource` now rejects that shape immediately.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Sonnet 5)
   
   Generated-by: Claude Code (Sonnet 5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to