kaxil commented on PR #72157: URL: https://github.com/apache/airflow/pull/72157#issuecomment-5722395938
Round 1 is all addressed at `65c6efd`, and I re-derived each thread against the code rather than going off the replies: `assigned_users` is passed unconditionally now, the 3.1.6 comparison boundary in the docs matches what `hitl.py` does at `3.1.5` versus `3.1.6`, the stale-list caveat is still accurate against this branch's base, and the old-core test sits inside the old-core class so the sub-3.1 compat lane actually runs it. One non-blocking doc thought, nothing gating: [`llm.rst` L283-285](https://github.com/apache/airflow/blob/65c6efde54dfc11c4fde13363484edcd47bc0b08/providers/common/ai/docs/operators/llm.rst#L283-L285) gives FAB as the concrete answer for `id`, and FAB is not the default auth manager. Since a wrong `id` locks out every reviewer on 3.1.0 through 3.1.5, as the next sentence says, it would help to name the default too: `[core] auth_manager` defaults to `SimpleAuthManager`, whose `get_id()` returns the username, so there `id` is the username from `simple_auth_manager_users`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
