kaxil opened a new pull request, #73300:
URL: https://github.com/apache/airflow/pull/73300
107 newsfragments on `main` document changes that are already published in
release notes, so the next release would print the same entries a second time.
The release process already calls for removing them ("Sync `RELEASE_NOTES.rst`
(including deleting relevant `newsfragments`)" in
[`dev/README_RELEASE_AIRFLOW.md`](https://github.com/apache/airflow/blob/e03cfa2f925495be3f8c5b751505aaaa29a58df4/dev/README_RELEASE_AIRFLOW.md#L1663)),
but the deletions were missed across several releases.
Removed: 105 in `airflow-core` (31 shipped in 3.2.0, 49 in 3.3.0, 25
backported into 3.3.1 or 3.3.2), one in `chart` (Helm Chart 1.22.0) and one in
`providers/microsoft/azure`. Kept: 33 in `airflow-core`, all merged after the
3.3.0 branch cut, and 11 in `chart`, all after 1.22.0. `towncrier build
--draft` still renders for both `airflow-core` and `chart` with the released
entries gone.
## How the list was derived
A fragment is removed only if the change it documents is reachable from a
release tag, which takes two independent signals:
1. the commit that added the fragment file is an ancestor of a release tag,
or
2. the PR number in the filename appears in a commit subject in a release
tag's history.
**Neither signal alone is enough.** A backport lands as `<title> (#original)
(#backport)`, so reading only the trailing PR number credits the commit to the
backport and leaves 25 fragments looking unreleased. Their entries are already
published under the backport number, for example ``Fix `airflow db clean` never
purging the `callback` table (#72899)`` in 3.3.2, whose fragment on `main` is
`70923.bugfix.rst`. In the other direction, a fragment named after an issue
rather than the merging PR is invisible to the second signal:
`58337.feature.rst` was added by #58583 and `60921.significant.rst` by #60940,
both of which shipped in 3.2.0 and are cited in that section of
`RELEASE_NOTES.rst`.
One near miss worth naming: `chart/newsfragments/65852.significant.rst`
reads like `Add requirePersistence option to worker logGroomerSidecar (#65884)`
in Helm Chart 1.22.0, but that is a separate PR on the chart 1.x line. #65852
exists only on `main`, for Chart 2.0, so its fragment stays.
The `.pre-commit-config.yaml` change drops four paths from the
inclusive-language hook's exclude list, all of them naming newsfragments that
no longer exist. Three were already dead before this PR, left behind by earlier
cleanups.
`check-newsfragment-pr-number` [filters on `.status !=
"removed"`](https://github.com/apache/airflow/blob/e03cfa2f925495be3f8c5b751505aaaa29a58df4/.github/workflows/check-newsfragment-pr-number.yml#L48),
so a deletion-only PR passes it without the `skip newsfragment check` label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
