amoghrajesh opened a new pull request, #73302:
URL: https://github.com/apache/airflow/pull/73302
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
### What
Fix for CI https://github.com/apache/airflow/actions/runs/35265542917
```
test_login.py::TestCreateTokenUnparsableBody::test_form_parser_error_keeps_its_own_detail
assert 422 == 400
```
`airflow-core` declared `starlette>=1.0.1`, so lowest-direct resolution
installed 1.0.1, a version whose `application/x-www-form-urlencoded` parser
enforces no limits at all.
### Current behaviour
In Starlette 1.0.1, only the multipart parser enforces `max_fields`. The
urlencoded `FormParser` has no field-count or field-size bound, and
`Request._get_form` does not wrap it in the `MultiPartException` to
`HTTPException(400)` translation that the multipart branch gets.
`parse_login_body` relies on that translation: it only converts
`ClientDisconnect`, and deliberately lets Starlette's own 400 (`"Too many
fields..."`) propagate rather than flattening it into the generic message.
Below Starlette `1.3.1` that reliance does not hold: a 2000-field body parses
cleanly, `username` and `password` come back `None`, and `LoginBody` validation
answers 422.
Beyond the test, this means the declared floor claimed support for a
configuration in which the unauthenticated `POST /auth/token` route parses a
urlencoded body with no `field-count` or `field-size` bound.
### Changes of Note
1.3.1 is the exact boundary, established by bisecting the published wheels:
| starlette | urlencoded `max_fields` | maps to 400 |
|---|---|---|
| 1.0.1 – 1.3.0 | no | no |
| 1.3.1+ | yes | yes |
Starlette's 1.3.1 notes: *"Enforce `max_fields` and `max_part_size` in
`FormParser`"* and *"Enforce `FormParser` limits in parser callbacks"*.
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
