potiuk commented on PR #72206:
URL: https://github.com/apache/airflow/pull/72206#issuecomment-5725726032
All three points landed in the meantime — flagging so the review isn't
re-read against the old diff.
**Dedicated helper.** `metadata_db_environment` is now its own define in
`chart/templates/_helpers.yaml`, sitting next to `jwt_secret_environment`
exactly as you suggested, rather than growing `standard_airflow_environment`.
**`AIRFLOW__DATABASE__SQL_ALCHEMY_CONN` variant.** Covered — it is one of
the two names in `METADATA_DB_VARS` at the top of `test_airflow_common.py`, and
it appears in the per-component expectations further down.
**jmespath.** The new assertions use it throughout, consistent with the rest
of the file.
On the Airflow 2 point: this chart already refuses to render for anything
older than 3.1.0 — `chart/templates/check-values.yaml` has
```
{{- if semverCompare "<3.1.0" .Values.airflowVersion }}
{{ required "This chart only supports Apache Airflow version 3.1.0 and
above." nil }}
```
so there is no Airflow 2 path on `main` that could lose these variables.
You're right that a backport to the 1.x chart line is a different matter and
would need doing by hand rather than cherry-picking — worth a tracking issue if
we intend to do it, but not something that changes this PR.
Could you take another look when you have a moment?
---
Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
