amirmor1 commented on code in PR #69855:
URL: https://github.com/apache/airflow/pull/69855#discussion_r4044411189
##########
providers/google/src/airflow/providers/google/cloud/operators/dataproc.py:
##########
@@ -2416,9 +2417,12 @@ class
DataprocCreateBatchOperator(GoogleCloudBaseOperator):
:param project_id: Optional. The ID of the Google Cloud project that the
cluster belongs to. (templated)
:param region: Required. The Cloud Dataproc region in which to handle the
request. (templated)
:param batch: Required. The batch to create. (templated)
- :param batch_id: Required. The ID to use for the batch, which will become
the final component
+ :param batch_id: Optional. The ID to use for the batch, which will become
the final component
Review Comment:
You're right — batch_id has always been optional in the signature (batch_id:
str | None = None), and execute() already had a branch logging "The batch ID
will be generated since it was not provided." The docstring saying "Required"
was simply stale. I corrected it here because this PR makes that optional path
more prominent, but it's a docs fix rather than a behaviour change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
