jason810496 commented on code in PR #73325:
URL: https://github.com/apache/airflow/pull/73325#discussion_r4047033878
##########
ts-sdk/adr/0001-mixed-lang-dag-interface.md:
##########
@@ -31,11 +31,9 @@ Proposed. Revised after the review on #72047.
2. **A bundle has one registration verb and serves itself.**
`bundle.register(...)` takes Dags and
task handlers alike, in any mixture, and `await bundle.serve()` starts the
runtime over them.
`Bundle` replaces `DagRegistry`, and the free `serveDags(registry)`
function goes with it.
-3. **task_id is optional but should probably be written out here.** Most of
the time because of
- naming convention difference between python and typescript, names won't
match. Omitting it defaults
- the id to the handler's function name — `new TaskHandler(transformStep)`
binds the `"transformStep"` fn to the
- "transformStep" task. On the other hand `new TaskHandler("transform_step",
transformStep)` will bind to
- "transform_step" task.
+3. **task_id is always written out**, because Python owns it. Renaming a
TypeScript function must
Review Comment:
```suggestion
3. **dag_id and task_id should always be written out**, because Python owns
it. Renaming a TypeScript function must
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
