shahar1 commented on code in PR #70531:
URL: https://github.com/apache/airflow/pull/70531#discussion_r4048597630
##########
providers/google/tests/unit/google/cloud/operators/test_functions.py:
##########
@@ -80,10 +80,25 @@ def test_missing_fields(self, mock_hook, body, message):
op.execute(None)
def test_body_empty(self):
+ op = CloudFunctionDeployFunctionOperator(
+ project_id="test_project_id", location="test_region", body={},
task_id="id"
+ )
with pytest.raises(AirflowException):
- CloudFunctionDeployFunctionOperator(
- project_id="test_project_id", location="test_region", body={},
task_id="id"
- )
+ op.execute(None)
+
+
@mock.patch("airflow.providers.google.cloud.operators.functions.CloudFunctionsHook")
+ def test_templated_body_deploys_after_rendering(self, mock_hook):
Review Comment:
Test passes on unmodified main, which means that it doesn't check an actual
regression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
