kaxil opened a new pull request, #73361: URL: https://github.com/apache/airflow/pull/73361
The `aset`/`adelete`/`aclear` examples under "Custom backends" in `task-and-asset-state-store.rst` forward `session=session` into synchronous `set`/`delete`/`clear` calls run via `asyncio.to_thread`. `BaseStoreBackend` types `session` as `AsyncSession | None` on the async methods and `Session | None` on the sync ones they call, so the example hands an async session to a parameter typed for a synchronous one, and does so inconsistently with the `aget` example immediately above, which never forwards `session` at all. The in-tree `MetastoreBackend` doesn't cross that boundary either: its async methods use a real async session via dedicated `_a*_state_store` helpers rather than forwarding into the sync path. This drops the `session=session` forwarding from `aset`/`adelete`/`aclear` so all four examples match `aget` and the base class's own guidance that non-SQLAlchemy backends can accept and ignore `session`. --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
