jason810496 opened a new pull request, #73372:
URL: https://github.com/apache/airflow/pull/73372

   # Go SDK: assert the panic value in `TestNewContextRejectsNilArgs`
   
   - **Depends on https://github.com/apache/airflow/pull/73277 get merged 
first** (only the last commit is new here).
   - **Diff for early review**: 
https://github.com/jason810496/airflow/compare/feature/go-sdk/airflow-context...feature/go-sdk/airflow-context-panic-message
   - related: 
https://github.com/apache/airflow/pull/73277#discussion_r4052069561
   
   ## Why
   
   `assert.Panics` passed for the nil ctx case whether or not `NewContext` 
checked it, because `context.WithValue` panics on a nil ctx by itself.
   
   ## What
   
   - Key each case in `TestNewContextRejectsNilArgs` by its expected panic 
value and assert with `assert.PanicsWithValue`, so every case is pinned to the 
check in `NewContext`.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [x] Yes, with help of Claude Code Opus 5 following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to