abhijeets25012-tech commented on code in PR #73383:
URL: https://github.com/apache/airflow/pull/73383#discussion_r4057123040


##########
airflow-core/src/airflow/cli/commands/scheduler_command.py:
##########
@@ -105,3 +105,4 @@ def _serve_health_check(enable_health_check: bool = False):
     finally:
         if sub_proc:
             sub_proc.terminate()
+            sub_proc.join()

Review Comment:
   You're right. The join() change only affects subprocess teardown and does 
not explain why the health-check server is not running in the first place. I 
initially focused on the subprocess lifecycle without establishing that it was 
the cause of the reported issue. I'll investigate the health-check process 
startup path and the changes between the affected Airflow versions, and update 
the PR with a fix that addresses the reported behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to