Eason09053360 opened a new pull request, #73409:
URL: https://github.com/apache/airflow/pull/73409

   ## Why
   
   `[api] maximum_page_limit` is documented as capping any limit a client asks 
for, but was only enforced inside `LimitFilter.depends`, on the query-parameter 
path. The two batch endpoints (`POST /dags/~/dagRuns/list`, `POST 
/dags/~/dagRuns/~/taskInstances/list`) read their page size from a request 
body, so FastAPI never invokes that dependency — an authenticated client could 
ask them for the whole table while the equivalent GET endpoints capped the same 
request. The cap arrived in #60989, which missed these two call sites.
   
   ## What
   
   - The clamp moves into a new `LimitFilter.clamp_to_maximum` in 
`common/parameters/base.py`; `depends` delegates to it, so both entry points 
share one definition.
   - Both batch routes build their `LimitFilter` through it.
   - A test per endpoint asserts a clamped page while `total_entries` reports 
the larger unclamped count; both fail without the fix.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 5)
   
   Generated-by: Claude Code (Opus 5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to