potiuk commented on PR #72289: URL: https://github.com/apache/airflow/pull/72289#issuecomment-5751609835
Thanks for this, and sorry it ends here — closing as superseded by #72103, through no fault of yours. The same one-line change landed on `main` on 2026-09-09 as [#72103](https://github.com/apache/airflow/pull/72103) (`e90b59dc3e`, "Use non-deprecated user_agent_entry param in DatabricksSqlHook"), and `providers/databricks/src/airflow/providers/databricks/hooks/databricks_sql.py:244` already reads `"user_agent_entry": self.user_agent_value`. Because both sides made the identical edit, git still reports this PR as mergeable — which hides the fact that the hook hunk would contribute nothing. Two notes for next time, both small: - The changelog edit would need dropping regardless: it sits under 7.19.0, which is already released (the unreleased section on `main` is 7.20.0), and it cites the issue number rather than the PR. Per [`providers/AGENTS.md`](https://github.com/apache/airflow/blob/main/providers/AGENTS.md), provider changelogs are regenerated by the release manager from `git log`, so routine bug fixes should not touch `changelog.rst` at all. - Rebasing on `main` before pushing an update is the quickest way to catch a race like this one. One part of your PR is still genuinely missing from `main`: #72103 shipped **without a test**, and there is no test asserting that `sql.connect` receives `user_agent_entry` and not `_user_agent_entry`. If you would like to open a small follow-up with just `test_get_conn_passes_user_agent_entry_without_underscore` (no hook change, no changelog edit), that would be a welcome contribution and I am happy to review it. --- > *This message was drafted by an AI-assisted tool and > confirmed by an Apache Airflow maintainer. If you think > something here is mistaken, please reply on the PR and a > maintainer will weigh in.* > > *More on how Apache Airflow handles maintainer review:* > [contributing-docs/05_pull_requests.rst](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
