potiuk commented on PR #71832:
URL: https://github.com/apache/airflow/pull/71832#issuecomment-5753037785
Heads-up: `MyPy providers checks` went red on my previous fixup, and it
turned out to be a real latent bug rather than a spurious annotation error.
`BatchJob.name` is `str | None`, so `job.name.replace("/", "-")` could raise
`AttributeError` when a job had neither `display_name` nor `name`. While `job`
was unannotated mypy never looked at it; adding `job: BatchJob` is what
surfaced it. I have pushed a follow-up that derives the name None-safely and
raises a clear `ValueError` when there is nothing to name the file after. Tests
and mypy are both clean locally.
So the annotation earned its keep — thanks for the patience on the extra
round-trip.
---
> *This message was drafted by an AI-assisted tool and
> confirmed by an Apache Airflow maintainer. If you think
> something here is mistaken, please reply on the PR and a
> maintainer will weigh in.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
