cool9850311 opened a new pull request, #73421:
URL: https://github.com/apache/airflow/pull/73421

   ## Why
   
   #73084 added `SetVariable` and `DeleteVariable` to the Go SDK task client, 
which completes the `variable-read-write` capability, but it did not flip the 
entry in `go-sdk/capabilities.yaml`. The compatibility matrix in 
`go-sdk/README.md` is generated from that manifest, so it still tells readers 
the Go SDK offers `GetVariable` only and that writes are unavailable over the 
comm socket.
   
   The Java (#72676) and TypeScript manifests already report the capability as 
supported, so the Go entry is the only one left disagreeing with its own SDK.
   
   Nothing catches this automatically: 
`scripts/ci/prek/lang_sdk_compat_matrix.py` validates the manifest's shape — 
key coverage, types, and that an unsupported entry carries no `since` — but it 
cannot check a declaration against the code it describes.
   
   ## What
   
   - `go-sdk/capabilities.yaml`: mark `variable-read-write` supported since 3.4 
and drop the note, which no longer holds.
   - `go-sdk/README.md`: regenerated by the `update-go-sdk-readme-matrix` prek 
hook.
   
   `taskflow-binding` is deliberately left alone. It reads `false` for the Go, 
Java and TypeScript manifests alike, so unlike this entry it is not a single 
SDK lagging behind its own code, and flipping it is a question for whoever 
added the dimension in #73314.
   
   ## Verification
   
   - `prek run update-go-sdk-readme-matrix --all-files` — regenerates, then 
passes on a second run
   - `prek run --from-ref upstream/main --stage pre-commit`
   
   The capability itself is already covered end to end by 
`test_go_sdk_variable_write.py`, added in #73084.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to