potiuk commented on code in PR #72174: URL: https://github.com/apache/airflow/pull/72174#discussion_r4058578938
########## providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake.py: ########## Review Comment: Done — both sites now go through the same validator. - `_SnowflakeOAuthManager.get_valid_oauth_token` validates `account` before building the default `…/oauth/token-request` URL (the validator moved up the module so it sits above its first use). - `SnowflakeCortexAgentHook._get_base_url` validates `account` too, so this doesn't need to be a follow-up. The line I drew: fields that *name* the account (`account`, `region`) are validated; fields that *are* the address (`token_endpoint`, `host`) stay whatever the user configured. Those two are an explicitly supplied base URL rather than an identifier being interpolated into one, so holding them to the identifier charset would reject legitimate values. Tests added for both new rejection paths. Locally: 438 passed, 11 skipped across the Snowflake provider; ruff and mypy clean. --- Drafted-by: Claude Opus 5; reviewed by @potiuk before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
