namanjain24-sudo opened a new pull request, #73455:
URL: https://github.com/apache/airflow/pull/73455
`EksDeleteClusterTrigger` reports a deleted cluster with `{"status":
"deleted"}`, but `EksDeleteClusterOperator.execute_complete` only logged
"Cluster deleted successfully." for the status `"success"`. In deferrable mode
that message was therefore never logged, although the deletion itself
completed. Only the log line was affected: `validate_execute_complete_event`
raises only when the event is `None`, so nothing failed.
The check now matches the status the trigger emits.
## Tests
- Added `test_execute_complete_logs_success_when_cluster_deleted`. It fails
without the change (`'Cluster deleted successfully.' in []`) and passes with it.
- `test_eks.py` for operators and triggers: 81 passed.
- `prek` pre-commit checks on the two changed files (ruff, ruff format and
the rest of the stage): passed, and `mypy` on `eks.py`: no issues.
- Not run locally: the `mypy-providers` and `check-template-fields-valid`
hooks, which need the Breeze CI image. This change does not touch template
fields.
related: #72982
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: a Gen-AI coding assistant, following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions).
I reviewed the change and ran the checks above.
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
