amoghrajesh commented on code in PR #72100:
URL: https://github.com/apache/airflow/pull/72100#discussion_r4059578244
##########
airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/ClearGroupTaskInstanceDialog.tsx:
##########
@@ -53,22 +53,37 @@ export const ClearGroupTaskInstanceDialog = ({ onClose,
open, taskInstance }: Pr
const { dagId = "", runId = "" } = useParams();
const groupId = taskInstance.task_id;
- const { isPending, mutate } = useClearTaskInstances({
- dagId,
- dagRunId: runId,
- onSuccessConfirm: onClose,
- });
-
const [clearTaskInstanceDefaultOptions] =
useClearTaskInstanceDefaultOptions();
+ const [keepTaskStateDefault] = useClearKeepTaskStateDefault();
const [selectedOptions, setSelectedOptions] =
useState<Array<string>>(clearTaskInstanceDefaultOptions);
const onlyFailed = selectedOptions.includes("onlyFailed");
const past = selectedOptions.includes("past");
const future = selectedOptions.includes("future");
const upstream = selectedOptions.includes("upstream");
const downstream = selectedOptions.includes("downstream");
+ const [keepTaskState, setKeepTaskState] = useState(keepTaskStateDefault);
const [note, setNote] = useState<string | null>(null);
+ const onCloseDialog = () => {
+ setNote(null);
+ setKeepTaskState(keepTaskStateDefault);
+ onClose();
+ };
+
+ useEffect(() => {
+ if (open) {
+ setNote(null);
+ setKeepTaskState(false);
Review Comment:
Fixed. The effect now resets to `keepTaskStateDefault` instead of hardcoded
false, and it's in the dep array, matching the sibling dialog.
##########
airflow-core/newsfragments/72100.significant.rst:
##########
@@ -0,0 +1,57 @@
+Clearing a task now discards its task state store entries by default
+
+Clearing a task instance discards its ``task_state_store`` entries, so the
next attempt starts from
+the beginning instead of resuming from a checkpoint or reconnecting to an
external job recorded by
+the attempt that was cleared.
+
+Retries are unaffected. They keep task state exactly as before, which is what
crash recovery relies
+on. Only a deliberate clear discards.
+
+This only applies to clearing individual task instances (the task-instance
clear endpoint / dialog,
+and ``airflowctl dags clear``, which clears every task instance in the matched
Dag run(s) through
+the same endpoint). Clearing an entire Dag run through the "Clear Run"
dialog/API, and marking a
+task as failed or success (which clears downstream tasks as a side effect),
still keep task state
+unconditionally today; extending discard-by-default to those paths is tracked
in
+`#72929 <https://github.com/apache/airflow/issues/72929>`_.
+
+**Why**
+
+Clearing means "run this again". A checkpoint records how far a task got, not
what it got there
+with, so resuming after the code or the upstream data changed left work done
before the fix in place
+and silently mixed it with the corrected work. Clearing a task whose external
job had already
+succeeded was worse: the operator read the stored result back and returned in
seconds having run
+nothing.
+
+**Keeping the old behaviour**
+
+Pass ``keep_task_state=True`` to the clear task instances endpoint, or tick
"keep task state" in the
Review Comment:
Fixed. Added a sentence pointing to Settings > Clearing > "Keep task state
on clear", noting it's a per-browser default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
