o-nikolas commented on code in PR #73295:
URL: https://github.com/apache/airflow/pull/73295#discussion_r4066649052


##########
airflow-core/src/airflow/cli/commands/dag_processor_command.py:
##########
@@ -33,12 +34,32 @@
 log = logging.getLogger(__name__)
 
 
+def _get_team_name(bundle_names: list[str] | None) -> str | None:
+    """
+    Return the team this Dag processor serves, or None when it serves no 
single team.
+
+    A bundle belongs to at most one team, so the processor is team-scoped only 
when every
+    bundle it parses belongs to the same team. A processor parsing all 
bundles, bundles of
+    several teams, or a team-less bundle alongside a team's own is not 
team-scoped.

Review Comment:
   Yeah, to me I think that makes the most sense. If the dag processor is 
serving many teams by parsing their dags then the job is also serving multiple 
teams and they'd all want to be aware. I hear that it affects the schema, which 
is annoying, I'm not sure the level of the impact. It might be one of the 
things that's worth fixing early now even though it's effort, or maybe it's way 
too much work for the payoff. I'll leave that up to you and won't block it 
:slightly_smiling_face:  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to