potiuk commented on PR #70904:
URL: https://github.com/apache/airflow/pull/70904#issuecomment-5768114519
**Heads-up on an incoming conflict — not a review.**
`@haseebmalik18`'s #71206 adds an `airflowctl tasks state` command, and it
brings a third copy of the block this PR consolidates:
```python
if (args.run_id is None) == (args.logical_date is None):
rich.print("[red]Provide either run_id or --logical-date, but not
both[/red]")
sys.exit(1)
run_id = args.run_id or _find_run_id_by_logical_date(api_client,
args.dag_id, args.logical_date)
```
I've approved that PR, so it will most likely land first. When it does, this
one will conflict in `task_command.py`, and the resolution is small: the new
`state` command's block collapses into another `resolve_dag_run_id(api_client,
args)` call, next to the two in `failed_deps` and `states_for_dag_run`.
Nothing to do right now. Flagging it so the conflict isn't a surprise when
it turns up, and so the extra call site reads as expected rather than as
something that crept in while this was waiting.
This note is only about the overlap — I haven't left a review on this PR
itself.
---
> *This message was drafted by an AI-assisted tool and confirmed by an
Airflow maintainer. If anything here looks wrong, please reply on the PR and a
maintainer will follow up.*
---
Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
