potiuk commented on code in PR #73506:
URL: https://github.com/apache/airflow/pull/73506#discussion_r4066910683
##########
providers/duckdb/README.rst:
##########
@@ -57,28 +60,5 @@ PIP package Version required
``duckdb`` ``>=1.2.0``
======================================= ==================
-Cross provider package dependencies
------------------------------------
-
-Those are dependencies that might be needed in order to use all the features
of the package.
-You need to install the specified providers in order to use them.
-
-You can install such cross-provider dependencies when installing from PyPI.
For example:
-
-.. code-block:: bash
-
- pip install apache-airflow-providers-duckdb[common.sql]
-
-
-============================================================================================================
==============
-Dependent package
Extra
-============================================================================================================
==============
-`apache-airflow-providers-common-sql
<https://airflow.apache.org/docs/apache-airflow-providers-common-sql>`_
``common.sql``
-============================================================================================================
==============
-
-DuckDB version compatibility
Review Comment:
Regenerating this README is the right call — it was hand-written in #72845,
and `AGENTS.md` § Boundaries says never *"edit generated files by hand when a
generation workflow exists"*. But the regeneration takes this section with it,
and the guidance isn't wrong — it's the one thing a deployment persisting
DuckDB files actually needs to know. After this lands it survives only as a
comment in `providers/duckdb/pyproject.toml`, where no user will ever see it.
Worth moving into `providers/duckdb/docs/` (`index.rst` or `operators.rst`)
either here or in a quick follow-up, so the template regeneration stops eating
it.
Separately, and worth recording so nobody "restores" it later: the *Cross
provider package dependencies* table this hunk also removes advertised a
`[common.sql]` extra that duckdb doesn't have —
`apache-airflow-providers-common-sql>=1.28.2` is a hard dependency in
`pyproject.toml` and is already in the Requirements table above. That deletion
is a fix, not a regression.
(duckdb isn't in this wave, so none of this reaches a published artifact —
repo only.)
##########
providers/openai/docs/changelog.rst:
##########
@@ -20,6 +20,19 @@
Changelog
---------
+2.0.0
+.....
+
+.. note::
Review Comment:
`.. warning::` rather than `.. note::` here? The rest of the wave uses
`warning` for breaking-change migration blocks (`amazon` 10.0.0, `edge3` 5.0.0,
`git` 1.0.0), and in this file specifically the note directly below is about
`response_kwargs` becoming a template field — non-breaking. As written the
silently-changed XCom shape and a template-field addition render at identical
visual weight.
##########
providers/microsoft/psrp/docs/changelog.rst:
##########
@@ -27,17 +27,24 @@
Changelog
---------
-Breaking changes
-~~~~~~~~~~~~~~~~
-
-* ``Stop defaulting PsrpOperator task_id to cmdlet``
+4.0.0
+.....
+.. note::
Review Comment:
Same nit as `openai`: `.. warning::` would match `amazon` 10.0.0, `edge3`
5.0.0 and `git` 1.0.0, which all use `warning` for their breaking-change
blocks. A required `task_id` on every existing `PsrpOperator` is squarely
warning-grade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
