seanghaeli commented on code in PR #71850:
URL: https://github.com/apache/airflow/pull/71850#discussion_r4067267781
##########
airflow-core/tests/unit/models/test_taskinstance.py:
##########
@@ -4190,6 +4195,71 @@ def
test_clear_task_instances_recalculates_dagrun_queued_deadlines(dag_maker, se
assert recalculated_count == 2
[email protected](
+ ("timing", "should_recalculate"),
+ [
+ pytest.param(DAGRUN_QUEUED_TIMING, True, id="queued"),
+ pytest.param(DAGRUN_CREATED_TIMING, False, id="created"),
+ ],
+)
+def test_clear_task_instances_recalculates_custom_queued_deadlines(
+ dag_maker, session, timing, should_recalculate
+):
+ """Test that clearing tasks recalculates custom deadlines registered as
queued-anchored."""
+
+ class CustomReference(BaseDeadlineReference):
Review Comment:
This test does not have an `_evaluate_with` for the deadline reference, so
it's not testing the critical function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
