justinpakzad opened a new pull request, #73512:
URL: https://github.com/apache/airflow/pull/73512
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
Snowpark container services jobs are often long running jobs and the
operator polls Snowflake until a terminal status is reached. As per the
`ResumableJobMixin` documentation this operator is a textbook candidate for
durable execution. If the worker is restarted or crashed mid-way through, the
next retry reconnects to the already running SPCS job instead of submitting a
duplicate. If the job has already completed, then polling is skipped and the
job finalized. If the prior job had failed or no longer exists, a fresh job is
submitted. By default the operator now runs in this durable mode. It only
applies to the synchronous polling path and has no effect with
`wait_for_completion=False` or `deferrable=True`.
Couple of changes worth mentioning:
- Both `poll_until_complete` and `get_job_result` can finalize the job
(check status, fetch logs, and drop the service) depending on the state of the
job upon reconnect, so a flag was introduced (_poll_until_complete_ran) to
avoid duplicate finalization. Similar approach to the SnowflakeSqlApiOperator.
- The status fetch was split into _describe_status which is used by the
polling loop so Snowflake errors still surface, and get_job_status, which is
used only for the reconnect decision. `get_job_status` catches an "object does
not exist" error (errno 2003) and returns a not-found sentinel, so a
non-existent service resubmits fresh instead of raising.
- Since `ResumableJobMixin` only exists on Airflow 3.3+, the operator falls
back to a stub on older versions so it stays importable and always submits
fresh (same as the other operators that have durable execution).
The existing operator tests were updated for the new methods and new tests
cover the durable paths. This was also tested end to end against a Snowflake
instance (please see screenshots in the comment below). A durable section was
also added to the docs.
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (Claude Opus 4.8)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
