miruky commented on PR #73423: URL: https://github.com/apache/airflow/pull/73423#issuecomment-5770764673
I inferred that behaviour from the existing deletion-error handling and docstring, rather than a user-reported requirement. I missed a consequence of extending it to partial success. If deletion succeeds for A but fails for B, the new exception prevents the batch from reaching XCom or the trigger event, even though A has already been deleted. Retrying can receive B again, but cannot reliably recover A. I reproduced this in both paths with mocked per-message deletion outcomes; the existing implementation still delivers the batch in that case. So I don't think failing on partial success is a safe default here. I've moved the PR to draft. Would preserving the current message delivery and logging the failed deletions be useful instead? B could still be redelivered, as today, but we would report the deletion failure without withholding A from downstream processing. --- Drafted-by: OpenAI Codex (GPT-6) (no human review before posting) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
