shubhamraj-git commented on PR #73419:
URL: https://github.com/apache/airflow/pull/73419#issuecomment-5771853721
Two additional pre-existing issues surfaced while reviewing this change. I
do not consider them blockers for this PR, but they are worth tracking:
1. `SFTPHookAsync._parse_extras()` compares the expanded constructor value
with the unexpanded `default_known_hosts` using `!=`. As a result, a
connection-level `known_hosts` extra overwrites even an explicit constructor
path. A regression test could construct
`SFTPHookAsync(known_hosts="/explicit/known_hosts")`, parse a connection
containing `{"known_hosts": "/connection/known_hosts"}`, and assert that the
explicit path wins, consistently with `SSHHookAsync`.
2. The concurrent SFTP worker hooks now preserve `no_host_key_check`, but
they still discard the parent hook's `remote_host`, port, username,
credentials, key file, proxy configuration, and other constructor overrides. In
particular, a directory can be enumerated through an explicit `remote_host`,
after which the workers connect to the original host from the connection. A
regression test could patch worker hook construction, configure a parent with a
different `remote_host`, and assert that every worker receives the effective
host and relevant connection settings.
---
Drafted-by: Codex (GPT-5); reviewed by @shubhamraj-git before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
