pierrejeambrun commented on code in PR #73435:
URL: https://github.com/apache/airflow/pull/73435#discussion_r4071619389
##########
ts-sdk/src/sdk/bundle.ts:
##########
@@ -237,21 +211,24 @@ export function validateOwnBundle(value: unknown,
accessor: string): asserts val
);
}
-/** Internal: every task handle this bundle can dispatch, across both kinds.
Not
- * re-exported from the package root: enumerating what the runtime dispatches
- * is the runtime's job. */
-export function listBundleTasks(bundle: Bundle): TaskRef[] {
- return [...entriesOf(bundle)].flatMap(([dagId, entry]) =>
- entryTaskIds(entry).map((taskId) => ({ dagId, taskId })),
- );
+/** Internal: close every Dag this bundle declared in TypeScript, so no task
can
+ * be added or wired afterwards. */
+export function closeBundleDags(bundle: Bundle): void {
Review Comment:
nit: "closing" as dag isn't intuitive to me. Maybe another word / concept
could be more explicit. (freeze/makeImmutable/finalizeBundle etc...)
I like finalizeBundle / finalizeBundleDags. (call finalize on each dags of
the bundle)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
