This is an automated email from the ASF dual-hosted git repository.

vincbeck pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/main by this push:
     new 883b5cc6c05 Log the success message when a deferred EKS cluster 
deletion completes (#73455)
883b5cc6c05 is described below

commit 883b5cc6c058bdbdead6750f56a18b03766583f7
Author: namanjain24-sudo <[email protected]>
AuthorDate: Tue Sep 22 19:48:10 2026 +0530

    Log the success message when a deferred EKS cluster deletion completes 
(#73455)
    
    EksDeleteClusterTrigger reports a deleted cluster with the status "deleted",
    but EksDeleteClusterOperator.execute_complete only logged the success 
message
    for the status "success", so in deferrable mode the message was never 
logged.
---
 providers/amazon/src/airflow/providers/amazon/aws/operators/eks.py | 2 +-
 providers/amazon/tests/unit/amazon/aws/operators/test_eks.py       | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/providers/amazon/src/airflow/providers/amazon/aws/operators/eks.py 
b/providers/amazon/src/airflow/providers/amazon/aws/operators/eks.py
index e4fa2efde42..cdb63543649 100644
--- a/providers/amazon/src/airflow/providers/amazon/aws/operators/eks.py
+++ b/providers/amazon/src/airflow/providers/amazon/aws/operators/eks.py
@@ -886,7 +886,7 @@ class EksDeleteClusterOperator(AwsBaseOperator[EksHook]):
     def execute_complete(self, context: Context, event: dict[str, Any] | None 
= None) -> None:
         validated_event = validate_execute_complete_event(event)
 
-        if validated_event["status"] == "success":
+        if validated_event["status"] == "deleted":
             self.log.info("Cluster deleted successfully.")
 
 
diff --git a/providers/amazon/tests/unit/amazon/aws/operators/test_eks.py 
b/providers/amazon/tests/unit/amazon/aws/operators/test_eks.py
index abd9b6c334d..8c663a23073 100644
--- a/providers/amazon/tests/unit/amazon/aws/operators/test_eks.py
+++ b/providers/amazon/tests/unit/amazon/aws/operators/test_eks.py
@@ -760,6 +760,12 @@ class TestEksDeleteClusterOperator:
         with pytest.raises(TaskDeferred):
             self.delete_cluster_operator.execute({})
 
+    def test_execute_complete_logs_success_when_cluster_deleted(self, caplog):
+        # EksDeleteClusterTrigger reports a deleted cluster with the status 
"deleted".
+        self.delete_cluster_operator.execute_complete({}, event={"status": 
"deleted"})
+
+        assert "Cluster deleted successfully." in caplog.messages
+
     @mock.patch("time.sleep", return_value=None)
     @mock.patch.object(Waiter, "wait")
     @mock.patch.object(EksHook, "list_nodegroups")

Reply via email to