wiasliaw commented on issue #63715: URL: https://github.com/apache/airflow/issues/63715#issuecomment-5778456778
I'd like to confirm the intended filter semantics. There are two possible shapes: 1. **A single time window `[from, to]`**: the "zoom" reading of this issue. The chart shows every task instance that *overlaps* the window: `start_date <= to AND (end_date >= from OR end_date IS NULL)`. Note the mapping is crossed: the window's *from* bounds the task's **end_date**, and the window's *to* bounds the task's **start_date**. This matches the two-parameter shape #64387 used (`start_date` / `end_date` as onewindow). 2. **Two per-field range filters**: a Start Date `[gte, lte]` range and an End Date `[gte, lte]` range, following the existing Grid filter convention (each pill filters one field). More expressive (e.g. "tasks that *ended* during an incident window"), but to zoom the user has to work out the crossed mapping themselves, which seems wrong for the use case described here. (My PR is implemented based on option 2.) Two questions: - should the UI expose a single time-window filter (option 1), or per-field ranges (option 2)? - When a window is active, should the Gantt x-axis clamp exactly to `[from, to]`, or to the min/max of the filtered bars (a partially overlapping bar would then stretch the axis beyond the window)? Drafted-by: Claude Code (Fable 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
