amoghrajesh opened a new pull request, #73515:
URL: https://github.com/apache/airflow/pull/73515
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
Fixing test failures seen in CI:
https://github.com/apache/airflow/actions/runs/35677754412/job/106590993360
Error:
```shell
________________________________________________________ ERROR at setup of
TestGetDagBundle.test_import_error_count_is_gated_like_the_collection
_________________________________________________________
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_bundles.py:287:
in viewer_client
mock.patch.object(
/usr/python/lib/python3.12/unittest/mock.py:1567: in __enter__
new = create_autospec(autospec, spec_set=spec_set,
/usr/python/lib/python3.12/unittest/mock.py:2835: in create_autospec
new = child_klass(parent=parent, name=entry, _new_name=entry,
/usr/python/lib/python3.12/unittest/mock.py:2139: in __init__
_safe_super(MagicMixin, self).__init__(*args, **kw)
/usr/python/lib/python3.12/unittest/mock.py:1121: in __init__
_safe_super(CallableMixin, self).__init__(
/usr/python/lib/python3.12/unittest/mock.py:460: in __init__
self._mock_add_spec(spec, spec_set, _spec_as_instance, _eat_self)
/usr/python/lib/python3.12/unittest/mock.py:511: in _mock_add_spec
raise InvalidSpecError(f'Cannot spec a Mock object. [object={spec!r}]')
E unittest.mock.InvalidSpecError: Cannot spec a Mock object.
[object=<MagicMock name='get_authorized_dag_ids' spec='method'
id='140314755300480'>]
_________________________________________________________ ERROR at setup of
TestGetDagBundleFiles.test_excludes_a_file_whose_dag_is_not_readable
_________________________________________________________
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_bundles.py:287:
in viewer_client
mock.patch.object(
/usr/python/lib/python3.12/unittest/mock.py:1567: in __enter__
new = create_autospec(autospec, spec_set=spec_set,
/usr/python/lib/python3.12/unittest/mock.py:2835: in create_autospec
new = child_klass(parent=parent, name=entry, _new_name=entry,
/usr/python/lib/python3.12/unittest/mock.py:2139: in __init__
_safe_super(MagicMixin, self).__init__(*args, **kw)
/usr/python/lib/python3.12/unittest/mock.py:1121: in __init__
_safe_super(CallableMixin, self).__init__(
/usr/python/lib/python3.12/unittest/mock.py:460: in __init__
self._mock_add_spec(spec, spec_set, _spec_as_instance, _eat_self)
/usr/python/lib/python3.12/unittest/mock.py:511: in _mock_add_spec
raise InvalidSpecError(f'Cannot spec a Mock object. [object={spec!r}]')
E unittest.mock.InvalidSpecError: Cannot spec a Mock object.
[object=<MagicMock name='get_authorized_dag_ids' spec='method'
id='140314848863120'>]
```
Those two are the only tests in the file that request two client fixtures at
once (`admin_client` plus `viewer_client`). All three client fixtures share one
`test_client`, and therefore one `SimpleAuthManager` instance, and each patched
`get_authorized_dag_ids` on it with `autospec=True`. The first fixture to
set up replaces the attribute with a `MagicMock`, so the second one's
`create_autospec` runs against a mock and raises.
The shared patch now lives in a single `readable_dag_ids` fixture the three
client fixtures depend on, so it is applied once. Each client fixture keeps
only what is specific to it.
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
