rjgoyln commented on code in PR #70936:
URL: https://github.com/apache/airflow/pull/70936#discussion_r4073187371
##########
task-sdk/src/airflow/sdk/api/client.py:
##########
@@ -1305,6 +1305,14 @@ def dags(self) -> DagsOperations:
return DagsOperations(self)
+def _has_json_body(response: httpx.Response) -> bool:
+ """Check whether a response declares a JSON body."""
+ # Media types are case-insensitive and may carry parameters (RFC 9110), so
a proxy that
Review Comment:
Thanks for the review.
Rebased onto current `main` and pushed, so CI is running against today’s
tree.
Added the newsfragment at `airflow-core/newsfragments/70936.bugfix.rst`.
On the nit, I added `# Kept in sync with <the other one>` to each copy
rather than merging the comments. The `operations.py` comment explains the
consequence of silently skipping the `ServerResponseError` path, so I felt it
was worth keeping there; the cross-reference points to the twin.
The `extra=` check was a good catch. I had verified that the `isinstance`
guard covered the body shape, but hadn’t established that the key collision is
currently harmless under the logger. Thanks for pointing that out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
