rjgoyln commented on PR #70758: URL: https://github.com/apache/airflow/pull/70758#issuecomment-5779080122
Rebased onto `main` and pushed as `f55fedb`; everything below is in that commit. ### On the ordering against `otel_on` This is deliberate. Airflow's span emission is not gated on `otel_on`; that flag only controls whether Airflow creates its own provider. If a distro owns the provider, the spans still reach it when `otel_on=False`, so putting this behind the flag would leave those spans with random IDs. I added a comment and a parametrised test to make this explicit. ### On the exporter settings Agreed — this is now documented in the warning, `traces.rst`, and the newsfragment. The existing exporter settings were already ineffective with a foreign provider, so the early return avoids constructing a provider that could not be installed. I also documented why adding another span processor to the borrowed provider would be incorrect. ### On the import paths Confirmed. The task SDK already imports this module, so the check is kept at the `configure_otel` entry point. I’ve documented that coupling there. Happy to switch the check to duck typing if you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
