zozo123 commented on PR #71676: URL: https://github.com/apache/airflow/pull/71676#issuecomment-5781541307
All three notes from your pass earlier today are addressed; the extra name is settled. **1. Command-timeout docs.** `docs/sandbox/backends.rst` now puts OpenSandbox on the Modal side of that sentence, with the stall case as the exception: > A timeout destroys an `sbx` sandbox and its files; Modal and a server-enforced OpenSandbox timeout preserve the sandbox and files. OpenSandbox destroys it only if the command event stream itself stalls past the client-side grace period. **2. Open-network specs.** `_get_network_policy` returns `None` when `block_network=False` and no allowlist is set, so a deployment without the egress sidecar can run an open-network spec. `allow_egress_to_cidrs` is now refused up front, naming the dns+nft read-back gap as the reason rather than accepting a policy it cannot prove is enforced. **3. Extra name.** Renamed to `opensandbox`, matching `modal`. Applied across `providers/common/ai/pyproject.toml`, `docs/installation.rst`, `docs/index.rst`, `README.rst` and the SDK-missing error message; no occurrence of the old spelling remains. While re-checking that rename I found it had shortened the extras-table cell by eight characters without re-padding the row, so the second column started inside the first column's span. docutils rejects that with "Malformed table. Text in column margin" and parses zero rows, which drops the whole Optional dependencies table from the rendered docs and from `README.rst` rather than just misaligning one line. Fixed in d12cf0e. 64/64 unit tests pass. Drafted-by: Claude Code (Claude Opus 5); reviewed by @zozo123 before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
