ashb commented on code in PR #70960:
URL: https://github.com/apache/airflow/pull/70960#discussion_r4075274130
##########
providers/http/provider.yaml:
##########
@@ -127,4 +127,14 @@ connection-types:
hidden-fields: []
relabeling: {}
placeholders: {}
- conn-fields: {}
+ conn-fields:
+ srv_lookup:
+ label: Use DNS SRV Lookup
+ description: >-
+ Whether to treat the Host field as a DNS SRV record name and resolve
the target
+ host/port at request time.
+ schema:
+ type:
+ - boolean
+ - "null"
+ default: false
Review Comment:
Nit: Shoudl the default be not set (`null`), rather than False? Not sure it
makes any difference mind you
##########
providers/http/docs/connections/http.rst:
##########
@@ -47,12 +47,23 @@ Password (optional)
Host (optional)
Specify the entire url or the base of the url for the service.
+ If "Use DNS SRV Lookup" is enabled, specify the DNS SRV record name instead
+ (e.g. ``_http._tcp.example.com``) - Note the actual host and port are
resolved from DNS at
+ request time and any value set in the Port field is ignored.
+
Port (optional)
- Specify a port number if applicable.
+ Specify a port number if applicable. Ignored when SRV lookup is enabled.
Schema (optional)
Specify the service type etc: http/https.
+Use DNS SRV Lookup (optional)
+ Treat the Host field as a DNS SRV record name and resolve the target
host/port at request time.
+
+ Targets are tried in `RFC 2782 <https://www.rfc-editor.org/rfc/rfc2782>`__
order: lowest priority
+ first, weighted random within the same priority. If a connection to a
target cannot be established,
+ the request fails over to the next target.
Review Comment:
Probably need to mention this needs the `srv` extra too? Here I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
