o-nikolas opened a new pull request, #73569:
URL: https://github.com/apache/airflow/pull/73569
A team-scoped plugin's timetables and priority weight strategies were usable
by any Dag in the deployment. Unlike executors or pools, the Dag author imports
the class and instantiates it themselves, so nothing team-aware inherently
about the class.
Dags are now checked as they are parsed. Surfacing as an import error for
that Dag, leaving the rest of the bundle to parse. A team's classes are refused
to teamless Dags as well as to other teams', matching how the operator extra
links and macros already behave: a plugin that should serve every Dag is one
that declares no team.
Only the classes reachable on a parsed Dag are checked, its timetable and
any non-string weight_rule. Partition mappers, windows and deadline references
are mapped to their owning teams but not yet inspected. This is future work.
NOTE: This is validation in the Dag processor, so it holds only as far as
that component's configuration is trusted; validating server side was
previously rejected during community review for other plugin components. It is
the same logical scoping the macros already document, not an isolation boundary.
Resolving the bundle's team was already duplicated between the executor and
pool checks, so it moves into one helper rather than gaining a third copy.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
