kaxil opened a new pull request, #73589: URL: https://github.com/apache/airflow/pull/73589
The Common AI sandbox pages say which boundary `SandboxToolset` sits at, but not what enforces it or what happens to a sandbox when the worker dies. A few statements also promised more than the code does. Docs only; no behaviour change. Additions: - **What enforces the boundary** (`sandbox/index.rst`): a table comparing Monty under code mode, a container on the worker host, the `sbx` microVM and Modal by isolation, where the code runs, and what reclaims the sandbox if the worker is killed. Swapping backends changes the enforcement and leaves what runs inside the boundary alone. - **Protections table** in "Security boundary": each control (tool selection, restricted interpreter, isolation, identity, network, approval, deadlines, audit), the question it answers, where it stops, and what provides it. - Modal's default resources: 0.125 CPU cores and 128 MiB requested, per Modal's [resources guide](https://modal.com/docs/guide/resources). - How teardown actually ends. Modal's `destroy` returns without waiting and the sandbox shows an exit status within about 35 s (measured in the `ModalSandboxBackend.destroy` docstring); `sbx` waits up to two minutes on `sbx rm -f`. A missed request leaves a Modal sandbox billing until `sandbox_timeout`, or `idle_timeout` if set. - `cost_limit` counts model spend only and does not bound sandbox compute. Corrections: - The pages said the sandbox is "destroyed" at run end and before output review. At that point teardown has only been requested. - A secret printed in the sandbox was described as always reaching the task log and XCom. `LoggingToolset` logs tool names, timings and (at DEBUG) arguments but never results, so the text now says the value can reach the agent's output, message history and traces. - The code mode paragraph under "When to choose it" had a broken sentence. --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
