bujjibabukatta commented on PR #72879: URL: https://github.com/apache/airflow/pull/72879#issuecomment-5790414473
Hi @jroachgolf84 and @Kunal8954, thanks for the review! I've pushed fixes for the points raised: Renamed _fetch_all_jobs() to public fetch_all_jobs() and updated its caller Trigger no longer mutates self.job_id — uses a local variable instead Confirmed the async pager already walks all pages via __aiter__, so pagination is covered On the "brute-force" listing concern — Dataflow's API has no get-by-name endpoint, only get-by-ID or list, so client-side filtering is the only option I'm aware of. Open to suggestions if there's a better approach. Thanks again for the time you both put into this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
