Eason09053360 commented on code in PR #72859:
URL: https://github.com/apache/airflow/pull/72859#discussion_r4078404416
##########
airflow-core/tests/unit/cli/commands/test_api_server_command.py:
##########
@@ -35,6 +37,22 @@
class TestCliApiServer(_CommonCLIUvicornTestClass):
main_process_regexp = r"airflow api-server"
+ def test_uses_worker_timeout_config_as_cli_default(self):
+ result = subprocess.run(
+ [
+ sys.executable,
+ "-c",
+ "from airflow.cli.cli_parser import get_parser; "
+
"print(f\"worker_timeout={get_parser().parse_args(['api-server']).worker_timeout}\")",
Review Comment:
Thanks for the patch! LGTM
Just one nit: `!r` would pin the type too — the f-string prints `321` for
both `321` and `'321'`, so this still passes with `type=int` removed.
```suggestion
"print(f\"worker_timeout={get_parser().parse_args(['api-server']).worker_timeout!r}\")",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
