namanjain24-sudo commented on PR #73535:
URL: https://github.com/apache/airflow/pull/73535#issuecomment-5811834012
Nice catch on the crash for a templated `target_time` here.
One thing worth checking before this lands: #72659 (merged 2026-09-20, a
couple of days before this PR was opened) already added a delimiter check right
above this block:
```python
if (
start_from_trigger
and isinstance(self.target_time, str)
and any(delimiter in self.target_time for delimiter in ("{{", "{%",
"{#"))
):
start_from_trigger = False
```
That already flips `start_from_trigger` to `False` whenever `target_time`
contains Jinja delimiters, before the new `try/except` block is ever reached.
So after rebasing, `test_async_start_from_trigger_with_templated_target_time`
(which uses `"{{ data_interval_end... }}"`) would still pass, but for the wrong
reason — the delimiter check short-circuits it, and the new `try/except` never
actually runs.
The `try/except` is still useful for a different case though: a
non-templated but unparseable `target_time` (a plain invalid string, no `{{
}}`). `timezone.parse` raises `pendulum.parsing.exceptions.ParserError`, which
subclasses `ValueError`, so that path is real and not covered by #72659. Might
be worth rebasing onto main and swapping the test to cover that case instead,
since the templated one is already handled.
Also noticed a couple of stray trailing-whitespace lines added in the test
file, and the `uv.lock` hunk downgrading
`apache-airflow-providers-clickhousedb` to `1.0.0` looks like local lockfile
drift rather than an intended change — probably worth dropping from the diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
