olegkachur-e commented on PR #72638: URL: https://github.com/apache/airflow/pull/72638#issuecomment-5815495280
Thank you for submitting the PR, addressing real problem. I think the behaviour of "stmth/" -> "dst/smth"(file) is a side effect of the `os.path.normpath()` call, that was introduced [fairly recently](https://github.com/apache/airflow/pull/67667), and never was a legit case. The "name/" should always mean a folder, so we should create a folder on dst or do no-op in any case. I think it makes sense to make additional parameter in a style "mind empty dirs" with default "False" value and and handle that. And if we don't mind empty dir we'd probably do not delete with move object command(?). Should also lead to least corner cases to handle. WDYT? @yuseok89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
