Adityakk9031 commented on PR #70946:
URL: https://github.com/apache/airflow/pull/70946#issuecomment-5819126629

   @potiuk @uros-b The PR title has been updated as requested.
   
   Regarding the scope: the entire PR is only +16 / -6 lines across 4 files to 
resolve basic Windows development/testing blockers:
   - \scripts/ci/prek/common_prek_utils.py\: explicit UTF-8 encoding for \ 
ead_text\ (replied to @ashb's question on the review thread as well).
   - \shared/observability/.../stats.py\: guard \os.register_at_fork\ with 
\hasattr\ for Windows compatibility.
   - \  est_supervisor.py\ / \  est_task_runner.py\: POSIX-only test skip 
markers on Windows.
   
   All CI checks are passing. Could we keep this unified since the diff is very 
small and cohesive around Windows compatibility, or would you still prefer it 
split into micro-PRs?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to