AlejandroMorgante commented on code in PR #72542:
URL: https://github.com/apache/airflow/pull/72542#discussion_r4098005477


##########
providers/amazon/src/airflow/providers/amazon/aws/hooks/eks.py:
##########
@@ -105,10 +105,8 @@ class NodegroupStates(Enum):
                 exit "$status"
             fi
 
-            # Use pure bash below to parse so that it's posix compliant
-            # Only the token line should be on stdout (stderr captured above)
-
-            last_line=${{output##*$'\\n'}}  # strip everything up to the last 
newline
+            # Keep only the token line even if a dependency logs to stdout.
+            last_line=$(printf '%s\\n' "$output" | tail -n 1)

Review Comment:
   Split into #73690 as requested — also drops those local imports. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to