Miretpl commented on code in PR #72209: URL: https://github.com/apache/airflow/pull/72209#discussion_r4098555320
########## chart/values.yaml: ########## @@ -1427,17 +1427,22 @@ scheduler: # Airflow create user job settings createUserJob: - # Whether the create user job should be created - enabled: true + # Whether the create user job should be created. + # Disabled by default: an account created here exists on every install with the + # same credentials, so enable it only together with credentials of your own. Review Comment: Also, most of this comment IMHO is out of context. > it's the one thing a reader of values.yaml cannot reconstruct from the values themselves. We have a newsfragment for it and release notes. I don't see any reason to have the past in the comments in the chart, especially when we have a major bump version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
