jasperjonkhans commented on code in PR #72460:
URL: https://github.com/apache/airflow/pull/72460#discussion_r4103398064
##########
airflow-core/newsfragments/72460.feature.rst:
##########
Review Comment:
Removed the newsfragment in e7f2725979.
---
Drafted-by: Cursor (Claude Opus 5.5) (no human review before posting)
##########
airflow-core/src/airflow/ui/src/pages/AssetsList/AssetsList.tsx:
##########
@@ -147,6 +148,8 @@ export const AssetsList = () => {
const { filterConfigs, handleFiltersChange, initialValues } =
useFiltersHandler(assetsFilterKeys);
+ const hasEventsParam = searchParams.get(SearchParamsKeys.HAS_EVENTS);
+ const hasEvents = hasEventsParam === "true" ? true : hasEventsParam ===
"false" ? false : undefined;
Review Comment:
Done in cbea736056: `hasEvents` is now parsed with the same `let` / `if`
pattern used for `paused` and `isFavorite` in `DagsList`.
---
Drafted-by: Cursor (Claude Opus 5.5) (no human review before posting)
##########
airflow-core/src/airflow/ui/public/i18n/locales/en/assets.json:
##########
@@ -49,6 +49,9 @@
"events": "Events",
"filters": {
"groupPlaceholder": "Search group",
+ "hasEvents": "Has Events",
+ "hasEventsFalse": "No",
+ "hasEventsTrue": "Yes",
Review Comment:
Done in cbea736056: moved them to top-level `yes` / `no` entries in
`common.json`, dropped `filters.hasEventsTrue` / `filters.hasEventsFalse` from
`assets.json`, and the Has Events filter options now use `common:yes` /
`common:no`.
---
Drafted-by: Cursor (Claude Opus 5.5) (no human review before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
