basantjamwal commented on issue #73237:
URL: https://github.com/apache/airflow/issues/73237#issuecomment-5830948859
Checked the repo — it's mixed. Grid's older filters
(`run_type_filter-${dagId}`, `dag_run_state_filter-${dagId}`, etc., from
#55082/#62797) are localStorage-only. But the newer pattern (#72281, adding an
Assets filter) skips localStorage entirely and wires filters straight into
`searchParams.ts` — no localStorage fallback.
So URL-only for the calendar's timeframe/granularity/run-status lines up
with where things are heading, not against it. localStorage for timezone/theme
matches existing docs and code too.
Agreed — going with URL params only, no localStorage fallback, for
timeframe, granularity, and run-status.
I'll open a PR with this approach: move `Calendar.tsx`'s state to
`useSearchParams`, add the new keys to `searchParams.ts`, and drop the existing
localStorage keys for these values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
