pierrejeambrun commented on code in PR #73723:
URL: https://github.com/apache/airflow/pull/73723#discussion_r4105494100
##########
ts-sdk/src/cli/pack.ts:
##########
@@ -215,8 +300,15 @@ export async function runPack(argv: readonly string[]):
Promise<void> {
platform: "node",
format: "esm",
target: "node22",
- // A digest is only worth taking over an artifact nobody reads or edits
in place.
- minify: true,
+ // Whitespace and syntax only. Identifiers stay: `dag.task(handler)`
takes
+ // the task id from the handler's name at run time, and `keepNames`
carries
+ // that name through any bundler-collision renames.
Review Comment:
Fixed in 709a42f1c30 — the three-flag minify split reverted to plain
`minify: true`, and the rationale comment is gone. Nothing in this PR depends
on identifier preservation; the earlier split had been kept in anticipation of
a follow-up PR that isn't part of this diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
