YAshhh29 commented on PR #71575: URL: https://github.com/apache/airflow/pull/71575#issuecomment-5835805754
Thanks @kaxil, all five are addressed. I rebased onto main, so this is a force-push and the SHAs in my earlier comments are stale. The new commits are `3c4c1b2c` (canonical form), `db2f5ae1` (`error=` in the warnings), `ebab1f46` (docs) and `209a06a0` (a spelling fix). The iterator and `set[str]` issues were regressions from my `to_jsonable_python` change, not pre-existing bugs, so thanks for catching them. Details for each are in the thread replies. Beyond what you flagged: - a set coming back from a tool was also unstable, so messages now dump in `mode="python"`. On a 451-message history this gives the same digest as main, so nothing in flight moves. - that change opened two ways to escape the handler: `AttributeError` from a malformed message, and `RecursionError` from a circular reference. Both now degrade to an uncached step. The docs moved to `durable_execution.rst` with #73523, so the paragraphs landed there. CI is green: 118 durable tests (88 on main). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
