mik-laj commented on issue #7142: [AIRFLOW-6539][AIP-21] Move Apache classes to providers.apache package URL: https://github.com/apache/airflow/pull/7142#issuecomment-573400868 I found an issue:. We have HDFS sensor in two places: https://github.com/apache/airflow/blob/master/airflow/contrib/sensors/hdfs_sensor.py https://github.com/apache/airflow/blob/master/airflow/sensors/hdfs_sensor.py but in this PR we have sensors from one location, because the file has been overwritten instead of the appended. You could verify this PR using following commands: ``` diff <(git show apache/master:airflow/contrib/hooks/pinot_hook.py) <(cat airflow/providers/apache/pinot/hooks/pinot.py) diff <(git show apache/master:tests/contrib/hooks/test_pinot_hook.py) <(cat tests/providers/apache/pinot/hooks/test_pinot.py) diff <(git show apache/master:airflow/contrib/hooks/spark_jdbc_hook.py) <(cat airflow/providers/apache/spark/hooks/spark_jdbc.py) diff <(git show apache/master:tests/contrib/hooks/test_spark_jdbc_hook.py) <(cat tests/providers/apache/spark/hooks/test_spark_jdbc.py) diff <(git show apache/master:airflow/contrib/hooks/spark_jdbc_script.py) <(cat airflow/providers/apache/spark/hooks/spark_jdbc_script.py) diff <(git show apache/master:airflow/contrib/hooks/spark_sql_hook.py) <(cat airflow/providers/apache/spark/hooks/spark_sql.py) diff <(git show apache/master:tests/contrib/hooks/test_spark_sql_hook.py) <(cat tests/providers/apache/spark/hooks/test_spark_sql.py) diff <(git show apache/master:airflow/contrib/hooks/spark_submit_hook.py) <(cat airflow/providers/apache/spark/hooks/spark_submit.py) diff <(git show apache/master:tests/contrib/hooks/test_spark_submit_hook.py) <(cat tests/providers/apache/spark/hooks/test_spark_submit.py) diff <(git show apache/master:airflow/contrib/hooks/sqoop_hook.py) <(cat airflow/providers/apache/sqoop/hooks/sqoop.py) diff <(git show apache/master:tests/contrib/hooks/test_sqoop_hook.py) <(cat tests/providers/apache/sqoop/hooks/test_sqoop.py) diff <(git show apache/master:airflow/contrib/operators/druid_operator.py) <(cat airflow/providers/apache/druid/operators/druid.py) diff <(git show apache/master:tests/contrib/operators/test_druid_operator.py) <(cat tests/providers/apache/druid/operators/test_druid.py) diff <(git show apache/master:airflow/contrib/operators/spark_jdbc_operator.py) <(cat airflow/providers/apache/spark/operators/spark_jdbc.py) diff <(git show apache/master:tests/contrib/operators/test_spark_jdbc_operator.py) <(cat tests/providers/apache/spark/operators/test_spark_jdbc.py) diff <(git show apache/master:airflow/contrib/operators/spark_sql_operator.py) <(cat airflow/providers/apache/spark/operators/spark_sql.py) diff <(git show apache/master:tests/contrib/operators/test_spark_sql_operator.py) <(cat tests/providers/apache/spark/operators/test_spark_sql.py) diff <(git show apache/master:airflow/contrib/operators/spark_submit_operator.py) <(cat airflow/providers/apache/spark/operators/spark_submit.py) diff <(git show apache/master:tests/contrib/operators/test_spark_submit_operator.py) <(cat tests/providers/apache/spark/operators/test_spark_submit.py) diff <(git show apache/master:airflow/contrib/operators/sqoop_operator.py) <(cat airflow/providers/apache/sqoop/operators/sqoop.py) diff <(git show apache/master:tests/contrib/operators/test_sqoop_operator.py) <(cat tests/providers/apache/sqoop/operators/test_sqoop.py) diff <(git show apache/master:airflow/contrib/sensors/hdfs_sensor.py) <(cat airflow/providers/apache/hdfs/sensors/hdfs.py) diff <(git show apache/master:tests/contrib/sensors/test_hdfs_sensor.py) <(cat tests/providers/apache/hdfs/sensors/test_hdfs.py) diff <(git show apache/master:airflow/hooks/druid_hook.py) <(cat airflow/providers/apache/druid/hooks/druid.py) diff <(git show apache/master:tests/hooks/test_druid_hook.py) <(cat tests/providers/apache/druid/hooks/test_druid.py) diff <(git show apache/master:airflow/hooks/hdfs_hook.py) <(cat airflow/providers/apache/hdfs/hooks/hdfs.py) diff <(git show apache/master:tests/hooks/test_hdfs_hook.py) <(cat tests/providers/apache/hdfs/hooks/test_hdfs.py) diff <(git show apache/master:airflow/hooks/hive_hooks.py) <(cat airflow/providers/apache/hive/hooks/hive.py) diff <(git show apache/master:tests/hooks/test_hive_hook.py) <(cat tests/providers/apache/hive/hooks/test_hive.py) diff <(git show apache/master:airflow/hooks/pig_hook.py) <(cat airflow/providers/apache/pig/hooks/pig.py) diff <(git show apache/master:tests/hooks/test_pig_hook.py) <(cat tests/providers/apache/pig/hooks/test_pig.py) diff <(git show apache/master:airflow/hooks/webhdfs_hook.py) <(cat airflow/providers/apache/hdfs/hooks/webhdfs.py) diff <(git show apache/master:tests/hooks/test_webhdfs_hook.py) <(cat tests/providers/apache/hdfs/hooks/test_webhdfs.py) diff <(git show apache/master:airflow/operators/druid_check_operator.py) <(cat airflow/providers/apache/druid/operators/druid_check.py) diff <(git show apache/master:tests/operators/test_druid_check_operator.py) <(cat tests/providers/apache/druid/operators/test_druid_check.py) diff <(git show apache/master:airflow/operators/hive_operator.py) <(cat airflow/providers/apache/hive/operators/hive.py) diff <(git show apache/master:tests/operators/test_hive_operator.py) <(cat tests/providers/apache/hive/operators/test_hive.py) diff <(git show apache/master:airflow/operators/hive_stats_operator.py) <(cat airflow/providers/apache/hive/operators/hive_stats.py) diff <(git show apache/master:tests/operators/test_hive_stats_operator.py) <(cat tests/providers/apache/hive/operators/test_hive_stats.py) diff <(git show apache/master:airflow/operators/pig_operator.py) <(cat airflow/providers/apache/pig/operators/pig.py) diff <(git show apache/master:airflow/sensors/hdfs_sensor.py) <(cat airflow/providers/apache/hdfs/sensors/hdfs.py) diff <(git show apache/master:tests/sensors/test_hdfs_sensor.py) <(cat tests/providers/apache/hdfs/sensors/test_hdfs.py) diff <(git show apache/master:airflow/sensors/hive_partition_sensor.py) <(cat airflow/providers/apache/hive/sensors/hive_partition.py) diff <(git show apache/master:tests/sensors/test_hive_partition_sensor.py) <(cat tests/providers/apache/hive/sensors/test_hive_partition.py) diff <(git show apache/master:airflow/sensors/metastore_partition_sensor.py) <(cat airflow/providers/apache/hive/sensors/metastore_partition.py) diff <(git show apache/master:tests/sensors/test_metastore_partition_sensor.py) <(cat tests/providers/apache/hive/sensors/test_metastore_partition.py) diff <(git show apache/master:airflow/sensors/named_hive_partition_sensor.py) <(cat airflow/providers/apache/hive/sensors/named_hive_partition.py) diff <(git show apache/master:tests/sensors/test_named_hive_partition_sensor.py) <(cat tests/providers/apache/hive/sensors/test_named_hive_partition.py) diff <(git show apache/master:airflow/sensors/web_hdfs_sensor.py) <(cat airflow/providers/apache/hdfs/sensors/web_hdfs.py) diff <(git show apache/master:tests/sensors/test_web_hdfs_sensor.py) <(cat tests/providers/apache/hdfs/sensors/test_web_hdfs.py) ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
