jeff3071 commented on code in PR #71437:
URL: https://github.com/apache/airflow/pull/71437#discussion_r4109984952
##########
providers/common/ai/src/airflow/providers/common/ai/hooks/pydantic_ai.py:
##########
@@ -203,12 +238,14 @@ def _get_provider_kwargs(
kwargs["base_url"] = base_url
return kwargs
- def _get_conn_and_extra(self) -> tuple[Connection, dict[str, Any]]:
+ def _get_conn_and_extra(self, conn_id) -> tuple[Connection, dict[str,
Any]]:
Review Comment:
I changed the type hint to `str`. Since `conn_id` has default value and is
always expected to be a string, its type should be str.
Changing the type hint to `str | None` would cause the mypy check to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
