KarthikMohankumar opened a new pull request, #73751:
URL: https://github.com/apache/airflow/pull/73751

   `secret.py` and `k8s_model.py` in the `cncf.kubernetes` provider were both 
on the `OVERLOOKED_TESTS` allowlist in `test_project_structure.py`.
   
   `Secret` already had tests, but they lived in 
`tests/unit/cncf/kubernetes/models/test_secret.py`. There is no `models` 
package on the source side, so the structure check never matched them to 
`secret.py`. This PR:
   
   - moves them to `tests/unit/cncf/kubernetes/test_secret.py`, next to where 
the source lives, and drops the now-empty `models/` test package
   - adds cases for constructor validation (invalid `deploy_type`, `key` 
without `deploy_target`), uppercasing of env deploy targets, 
`__eq__`/`__hash__`/`__repr__`, and a check that `attach_to_pod` doesn't mutate 
the input pod
   - adds `test_k8s_model.py` covering `append_to_pod`: `None` and empty lists 
return the pod unchanged, and each object receives the previous object's result
   - removes both entries from `OVERLOOKED_TESTS`
   
   Tests only. No change to runtime behaviour.
   
   related: #35442
   
   Checks run locally:
   - `uv run --project providers/cncf/kubernetes pytest 
tests/unit/cncf/kubernetes/test_secret.py 
tests/unit/cncf/kubernetes/test_k8s_model.py`: 19 passed
   - 
`test_project_structure.py::TestProjectStructure::test_providers_modules_should_have_tests`:
 passed
   - `prek run --stage pre-commit` on the changed files (ruff, ruff-format, 
mypy-devel-common and the other applicable hooks): passed. `ast-grep` was 
skipped locally because it could not download its Node runtime.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 5.5)
   
   Generated-by: Claude Code (Opus 5.5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to